Skip to content

chore: update GitHub actions and fastlane#1494

Open
HashEngineering wants to merge 2 commits into
masterfrom
chore/update-github-actions-fastlane
Open

chore: update GitHub actions and fastlane#1494
HashEngineering wants to merge 2 commits into
masterfrom
chore/update-github-actions-fastlane

Conversation

@HashEngineering

@HashEngineering HashEngineering commented Jun 16, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

Issue being fixed or feature implemented

Related PR's and Dependencies

Screenshots / Videos

How Has This Been Tested?

  • QA (Mobile Team)

Checklist:

  • I have performed a self-review of my own code and added comments where necessary
  • I have added or updated relevant unit/integration/functional/e2e tests

Summary by CodeRabbit

  • Chores
    • Expanded continuous integration pipeline to support additional feature and bugfix branch naming patterns for broader automation coverage
    • Updated default build environment configuration for manual distributions
    • Enhanced build artifact handling with improved validation of symbol mapping files

@HashEngineering HashEngineering self-assigned this Jun 16, 2026
@coderabbitai

coderabbitai Bot commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e23f1d3b-421f-4dd4-a9cb-231eab323045

📥 Commits

Reviewing files that changed from the base of the PR and between a141bc3 and 134c144.

📒 Files selected for processing (4)
  • .github/workflows/dashwallet.yml
  • .github/workflows/ktlint.yml
  • .github/workflows/manual_distribution.yml
  • fastlane/Fastfile
📝 Walkthrough

Walkthrough

Branch trigger filters in dashwallet.yml and ktlint.yml are updated to include feat/* and fix/* patterns. The manual_distribution.yml workflow changes the default flavor input from staging to _testNet3. The Fastfile :upload lane gains ProGuard mapping file path resolution, existence validation, and passes the mapping file to supply.

Changes

CI/CD Workflow and Upload Configuration

Layer / File(s) Summary
Branch trigger filter alignment
.github/workflows/dashwallet.yml, .github/workflows/ktlint.yml		 Both workflows expand their pull_request branch filters to include feat/* and fix/*; ktlint.yml also removes the dashpay-* pattern.
Distribution defaults and mapping upload
.github/workflows/manual_distribution.yml, fastlane/Fastfile		 The manual distribution flavor input default is changed from staging to _testNet3; the Fastfile :upload lane now derives the mapping.txt path, raises a user error if it is missing, and passes it to supply.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐇 A bunny hops through branches new,
feat/* and fix/* now trigger the queue.
No more staging, try _testNet3!
The mapping file checked — uploads are free.
The CI garden grows tidy and true. 🌿

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: update GitHub actions and fastlane' accurately describes the main changes across all modified files, which involve updates to GitHub Actions workflows and fastlane configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/update-github-actions-fastlane

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abaranouski abaranouski Awaiting requested review from abaranouski

Assignees

@HashEngineering HashEngineering

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@HashEngineering